Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rules for LinkedIn #194075

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

SpotlightForBugs
Copy link
Contributor

@SpotlightForBugs SpotlightForBugs commented Dec 4, 2024

Creating the pull request

Please include a summary of the change and which issue is fixed
If the related issue does not exist in our repository, please create it before making pull request
It is highly recommended to use our Web Reporting Tool instead of creating an issue on GitHub directly
Please note, that we verify every pull request manually, so it may take time to apply it

Prerequisites

To avoid invalid pull requests, please check and confirm following terms

  • This is not an ad/bug report;
  • My code follows the guidelines and syntax of this project;
  • I have performed a self-review of my own changes;
  • My changes do not break web sites, apps and files structure.

What problem does the pull request fix?

#194071

If the problem does not fall under any category that is listed here, please write a comment below in corresponding section

  • Missed ads or ad leftovers;
  • Website or app doesn't work properly;
  • AdGuard gets detected on a website;
  • Missed analytics or tracker;
  • Social media buttons — share, like, tweet, etc;
  • Annoyances — pop-ups, cookie warnings, etc;
  • Filters maintenance.

What issue is being fixed?

Enter the issue address

Example: #194071

Add your comment and screenshots

If possible, a screenshot of a page or application should not be cropped too much. Otherwise, it is not always clear where the element is located

Please look at #194071 for screenshots of the problem.
I can't provide screenshots for privacy reasons, but all of the problems in the images are fixed by this PR

  1. Your comment

LinkedIn has

  • fake chats that are ads
  • upsells everywhere
  • tracking parameters everywhere

I've fixed that.

Terms

  • By submitting this issue, I agree that pull request does not contain private info and all conditions are met

SpotlightForBugs

This comment was marked as off-topic.

Comment on lines +181 to +205
www.linkedin.com##span:has-text(Promoted):upward(8)
www.linkedin.com##span:has-text(Promoted)
www.linkedin.com##li:has-text(Promoted)
www.linkedin.com##span:has-text(Suggested):upward(8)
www.linkedin.com##span:has-text(Suggested)
www.linkedin.com##li:has-text(Suggested)
www.linkedin.com##span:has-text(Recommended):upward(8)
www.linkedin.com##span:has-text(Recommended)
www.linkedin.com##li:has-text(Recommended)
www.linkedin.com##span:has-text(orgeschlagen):upward(8)
www.linkedin.com##span:has-text(orgeschlagen)
www.linkedin.com##li:has-text(orgeschlagen)
www.linkedin.com##span:has-text(obs recommende):upward(8)
www.linkedin.com##span:has-text(obs recommende)
www.linkedin.com##span:has-text(esponsert):upward(8)
www.linkedin.com##span:has-text(esponsert)
www.linkedin.com##li:has-text(esponsert)
www.linkedin.com##li:has-text(obs recommende)
www.linkedin.com##.premium-upsell-link
www.linkedin.com##div.artdeco-card.overflow-hidden:has(a[class*="premium-upsell"])
www.linkedin.com##section.ad-banner-container
www.linkedin.com##div.mn-sales-navigator-upsell.artdeco-card
www.linkedin.com##section.artdeco-card:has(div[class^="jobs-home-upsell-"])
www.linkedin.com##div:has(a[class^="premium-upsell-link"])
www.linkedin.com##span.global-nav__secondary-premium-cta-text:upward(1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better use regexp, and :has instead of :upward. These rules has low performance.
Anlso need examples of ads - I can't reproduce.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the examples, just create a LinkedIn account (wait for 7 days or so)
Tested languages:
German
English

Feel free to apply the changes, I personally am not a professional AdGuard rules writer.

I use the aforementioned rules and I have no ads on LinkedIn anymore whatsoever

Comment on lines +496 to +501
www.linkedin.com##span:has-text(orgeschlagen):upward(8)
www.linkedin.com##span:has-text(orgeschlagen)
www.linkedin.com##li:has-text(orgeschlagen)
www.linkedin.com##span:has-text(esponsert):upward(8)
www.linkedin.com##span:has-text(esponsert)
www.linkedin.com##li:has-text(esponsert)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

Comment on lines +1781 to +1782
! Remove user survey back to LinkedIn button tracking parameter
||linkedin.com^removeparam=trk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need steps to reproduce.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is happening when you click on an ad that asks you how you'd like to use premium.

There are tracking parameters there and also upon quitting the survey prematurely

Comment on lines +1788 to +1792
! Premium upsell survey tracking
||linkedin.com/premium/survey^$removeparam=isSS
||linkedin.com/premium/survey^$removeparam=referenceId
||linkedin.com/premium/survey^$removeparam=upsellOrderOrigin
||linkedin.com/premium/survey^$removeparam=destRedirectURL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need steps to reproduce.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants